Fix failing tests from pr #38

goldhand · Jan 9, 2017 · 6c587bb · 6c587bb
1 parent 8c407cb
commit 6c587bb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -14,7 +14,7 @@ const
 const DEFAULT_OPTIONS = {
   cacheId: DEFAULT_CACHE_ID,
   filename: DEFAULT_WORKER_FILENAME,
-  forceDelete: true
+  forceDelete: false,
 };
 
 /**
@@ -42,6 +42,7 @@ const DEFAULT_OPTIONS = {
  * @param {string} [options.filename] - Service worker filename, default is 'service-worker.js'
  * @param {string} [options.filepath] - Service worker path and name, default is to use webpack.output.path + options.filename
  * @param {RegExp} [options.staticFileGlobsIgnorePatterns[]] - Define an optional array of regex patterns to filter out of staticFileGlobs
+ * @param {boolean} [options.forceDelete=false] - pass force option to del
  */
 class SWPrecacheWebpackPlugin {
 
@@ -117,7 +118,7 @@ class SWPrecacheWebpackPlugin {
         ...this.overrides,
       };
 
-    return del(filepath, { ...this.options.forceDelete }).then(() => {
+    return del(filepath, {force: this.options.forceDelete}).then(() => {
       return swPrecache.write(filepath, workerOptions);
     });
   }

diff --git a/test/plugin.spec.js b/test/plugin.spec.js
@@ -12,6 +12,7 @@ import fs from 'fs';
 const DEFAULT_OPTIONS = {
   cacheId: 'sw-precache-webpack-plugin',
   filename: 'service-worker.js',
+  forceDelete: false,
 };
 
 const webpackConfig = () => {