Prevent the Babel plugin from breaking the output of babel-node (#374)

* prevent the babel plugin from breaking the output of babel-node the tagger code inserted by the babel plugin at the end of every file is an IIFE, which happens to break babel-node when it's loaded. by changing it to a variable declaration (that is still immediately invoked), it works the same way and doesn't break the plugin. * comment why we assigned the tagger function to an unused variable
gaearon · Sep 22, 2016 · 1058ad9 · 1058ad9
1 parent bc263de
commit 1058ad9
Show file tree

Hide file tree

Showing 13 changed files with 30 additions and 26 deletions.
diff --git a/src/babel/index.js b/src/babel/index.js
@@ -4,8 +4,11 @@ const buildRegistration = template(
   '__REACT_HOT_LOADER__.register(ID, NAME, FILENAME);'
 );
 const buildSemi = template(';');
+
+// We're making the IIFE we insert at the end of the file an unused variable
+// because it otherwise breaks the output of the babel-node REPL (#359).
 const buildTagger = template(`
-(function () {
+var UNUSED = (function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
@@ -141,7 +144,7 @@ module.exports = function plugin(args) {
           /* eslint-enable */
         },
 
-        exit({ node }) {
+        exit({ node, scope }) {
           const registrations = node[REGISTRATIONS];
           node[REGISTRATIONS] = null; // eslint-disable-line no-param-reassign
 
@@ -150,6 +153,7 @@ module.exports = function plugin(args) {
           node.body.push(buildSemi());
           node.body.push(
             buildTagger({
+              UNUSED: scope.generateUidIdentifier(),
               REGISTRATIONS: registrations,
             })
           );

diff --git a/test/babel/fixtures/bindings/expected.js b/test/babel/fixtures/bindings/expected.js
@@ -22,7 +22,7 @@ const _default = React.createClass({});
 export default _default;
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
@@ -38,6 +38,6 @@ export default _default;
   __REACT_HOT_LOADER__.register(E, "E", __FILENAME__);
 
   __REACT_HOT_LOADER__.register(_default, "default", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/class-properties/arguments/expected.js b/test/babel/fixtures/class-properties/arguments/expected.js
@@ -8,12 +8,12 @@ class Foo {
 }
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(Foo, "Foo", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/class-properties/block-body/expected.js b/test/babel/fixtures/class-properties/block-body/expected.js
@@ -10,12 +10,12 @@ class Foo {
 }
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(Foo, "Foo", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/class-properties/default-params/expected.js b/test/babel/fixtures/class-properties/default-params/expected.js
@@ -10,12 +10,12 @@ class Foo {
 }
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(Foo, "Foo", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/class-properties/destructured-params/expected.js b/test/babel/fixtures/class-properties/destructured-params/expected.js
@@ -10,12 +10,12 @@ class Foo {
 }
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(Foo, "Foo", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/class-properties/expression-body/expected.js b/test/babel/fixtures/class-properties/expression-body/expected.js
@@ -10,12 +10,12 @@ class Foo {
 }
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(Foo, "Foo", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/class-properties/nested-arguments/expected.js b/test/babel/fixtures/class-properties/nested-arguments/expected.js
@@ -10,12 +10,12 @@ class Foo {
 }
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(Foo, "Foo", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/class-properties/nested-new.target/expected.js b/test/babel/fixtures/class-properties/nested-new.target/expected.js
@@ -9,12 +9,12 @@ class Foo {
 }
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(Foo, "Foo", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/class-properties/new.target/expected.js b/test/babel/fixtures/class-properties/new.target/expected.js
@@ -7,12 +7,12 @@ class Foo {
 }
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(Foo, "Foo", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/counter/expected.js b/test/babel/fixtures/counter/expected.js
@@ -21,14 +21,14 @@ var _default = function _default() {
 exports.default = _default;
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(Counter, "Counter", __FILENAME__);
 
   __REACT_HOT_LOADER__.register(_default, "default", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/issue-246/expected.js b/test/babel/fixtures/issue-246/expected.js
@@ -13,12 +13,12 @@ function spread() {
 }
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(spread, "spread", __FILENAME__);
-})();
+}();
 
 ;
diff --git a/test/babel/fixtures/name-clash/expected.js b/test/babel/fixtures/name-clash/expected.js
@@ -3,14 +3,14 @@ const _default2 = 42;
 export default _default2;
 ;
 
-(function () {
+var _temp = function () {
   if (typeof __REACT_HOT_LOADER__ === 'undefined') {
     return;
   }
 
   __REACT_HOT_LOADER__.register(_default, "_default", __FILENAME__);
 
   __REACT_HOT_LOADER__.register(_default2, "default", __FILENAME__);
-})();
+}();
 
 ;