-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI – Activity feed webhook automations #19096
UI – Activity feed webhook automations #19096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks super clean 🧼 I'll test the UI Monday morning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On first load, I'm getting this error:
I think we need to account for undefined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nm see the mocks, ty!
b54ac47
into
feature_14722-activity-feed-webhooks
_This PR is the direct-to-`main` replacement for #19096, which merged to a now-defunct feature branch_ ## Addresses #19052 - update config, webhook interfaces, mock - clean up deprecated Sandbox code - implement Activity Feed Automations Modal and associated logic - Also addresses #19284 ![Screenshot-2024-05-24-at-21725PM](https://github.com/fleetdm/fleet/assets/61553566/1afc62f7-eeb3-49a8-a545-b971f2a19921) - [x] Changes file added for user-visible changes in `changes/` - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Addresses #19052
- [ ] Changes file added for user-visible changes inwill include with full feature branch mergechanges/
- [ ] Manual QA for all new/changed functionality– this branch is ready to plug-and-play with the backend changes, meaning it will not successfully build on its own until the expected fields are returned from the API. One can easily replace relevant lines with mocked data for experimentation if so desired.