Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional stats #19078

Merged
merged 26 commits into from
May 24, 2024
Merged

additional stats #19078

merged 26 commits into from
May 24, 2024
+91 −24

Conversation

sharon-fdm
Copy link
Contributor

@sharon-fdm sharon-fdm commented May 16, 2024 •
edited

Additional telemetry stats to report to Heroku.
FYI - @eashaw, we could later add to datadog as well.

@sharon-fdm sharon-fdm mentioned this pull request May 17, 2024
Open
@sharon-fdm sharon-fdm marked this pull request as ready for review May 17, 2024 15:42
@sharon-fdm sharon-fdm requested a review from a team as a code owner May 17, 2024 15:42
@sharon-fdm sharon-fdm requested a review from lucasmrod May 17, 2024 15:42
lucasmrod
lucasmrod requested changes May 17, 2024
View reviewed changes
Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Left a couple of nit comments.

  • Missing changes/ file.
  • Add tests to server/datastore/mysql/statistics_test.go.

@sharon-fdm @noahtalerman
Update cmd/fleet/serve_test.go
f486a85 
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
@sharon-fdm sharon-fdm requested a review from lucasmrod May 24, 2024 18:35
lucasmrod
lucasmrod approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please create a separate issue to change the statistics cron job to use the DB reader instance instead of the DB writer instance.

@lucasmrod lucasmrod self-assigned this May 24, 2024
@sharon-fdm sharon-fdm merged commit f75f077 into main May 24, 2024
12 checks passed
@sharon-fdm sharon-fdm deleted the additional_stats branch May 24, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getvictor getvictor getvictor left review comments

@noahtalerman noahtalerman noahtalerman left review comments

@lucasmrod lucasmrod lucasmrod approved these changes

Assignees

@lucasmrod lucasmrod

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sharon-fdm @lucasmrod @getvictor @noahtalerman