feat: macOS DDM support #17886

roperzh · 2024-03-27T13:45:46Z

PR for docs update: #17888

Checklist for submitter

If some of the following don't apply, delete the relevant line.

Changes file added for user-visible changes in changes/ or orbit/changes/.
See Changes files for more information.
Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
Added/updated tests
If database migrations are included, checked table schema to confirm autoupdate
For database migrations:
- Checked schema for all modified table for columns that will auto-update timestamps during migration.
- Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
Manual QA for all new/changed functionality

This includes the base types and the request handlers to reduce the chances of conflicts.

it delegates any extra unmarshaling to the caller. We might consider building our own types in the future instead of relying on micromdm, but these are used only for tests right now.

this is to prevent nanomdm to send the DeclarativeManagement command every time the host checks in.

…nd `declaration/.../...` (#17679)

…labels (#17719)

Co-authored-by: Jahziel Villasana-Espinoza <jahziel@fleetdm.com>

Follow up for #17402

Improvements and fixes I found while integrating this - Renamed db columns to match the profile tables for consistency - Added columns to `host_mdm_apple_declarations` - Removed `team_declaration_checksum_view` - Remove the ad-hoc `MDMAppleRecordDeclarativeCheckIn`, I confused myself by developing this using tests, the device actually sends an `Acknowledged` response, which is recorded by nano - Fixed bugs in the `declaration/../..` endpoints - The prefix for the endpoint is `declaration` without `s` - The response needs to include a `ServerToken`, otherwise the declaration fails

relates to #17416 update UI to support new DDM profile types. this includes: - updating Custom settings page - updating the os settings modal - [x] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [x] Manual QA for all new/changed functionality

for #17399

for #17404. I couldn't find tests for this portion of the code, so full tests for this section will need to be added during freeze.

for #17408

relates to #17409 adds the ddm activities to the UI. - [x] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. - [x] Manual QA for all new/changed functionality

…cOS declarations (#17866) Issue #17619 --------- Co-authored-by: Roberto Dip <dip.jesusr@gmail.com>

#17792

for #17409

#17685

relate to #17416 update to uploading, downloading, and deleting ddm profiles. - [x] Manual QA for all new/changed functionality

codecov · 2024-03-27T15:02:55Z

Codecov Report

Attention: Patch coverage is 76.13010% with 433 lines in your changes are missing coverage. Please review.

Project coverage is 65.53%. Comparing base (1777b9c) to head (94c55f9).

Files	Patch %	Lines
server/service/apple_mdm.go	58.77%	113 Missing and 35 partials ⚠️
server/datastore/mysql/apple_mdm.go	86.52%	86 Missing and 32 partials ⚠️
server/mock/datastore_mock.go	4.25%	45 Missing ⚠️
server/service/mdm.go	77.19%	23 Missing and 3 partials ⚠️
server/fleet/activities.go	14.28%	24 Missing ⚠️
...l/migrations/tables/20240327115530_AddDDMTables.go	88.23%	10 Missing and 4 partials ⚠️
...e/cards/ActivityFeed/ActivityItem/ActivityItem.tsx	0.00%	12 Missing ⚠️
...ngsModal/OSSettingsTable/OSSettingsTableConfig.tsx	25.00%	6 Missing ⚠️
server/datastore/mysql/mdm.go	87.50%	4 Missing and 2 partials ⚠️
server/datastore/mysql/mysql.go	80.64%	4 Missing and 2 partials ⚠️
... and 10 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17886      +/-   ##
==========================================
+ Coverage   65.37%   65.53%   +0.16%     
==========================================
  Files        1206     1208       +2     
  Lines      110310   111913    +1603     
  Branches     2592     2595       +3     
==========================================
+ Hits        72110    73346    +1236     
- Misses      32688    32977     +289     
- Partials     5512     5590      +78

Flag	Coverage Δ
backend	`66.57% <77.01%> (+0.17%)`	⬆️
frontend	`51.21% <23.33%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Roberto Dip and others added 26 commits March 14, 2024 18:08

add schema for DDM (#17636)

dc87ac2

#17405

add base types and handlers for DDM (#17657)

d261762

This includes the base types and the request handlers to reduce the chances of conflicts.

Add DDM service struct, basic handlers, and test client (#17671)

48b31a0

improve mdmtest package to handle any kind of command (#17673)

f5cf156

it delegates any extra unmarshaling to the caller. We might consider building our own types in the future instead of relying on micromdm, but these are used only for tests right now.

record declarative checkin command responses (#17693)

e26d234

this is to prevent nanomdm to send the DeclarativeManagement command every time the host checks in.

fix mysql 8+ test (#17702)

93f040f

Add macOS DDM protocol endpoints for tokens, declaration-items, a…

3d73174

…nd `declaration/.../...` (#17679)

Merge branch 'main' into feat-macos-ddm

8a137ff

Update DDM protocol endpoints to use host UUID in support of profile …

d56d0cd

…labels (#17719)

Merge branch 'main' into feat-macos-ddm

d9f9d28

Update backend APIs for macOS DDM (#17734)

01e3b94

Co-authored-by: Jahziel Villasana-Espinoza <jahziel@fleetdm.com>

Update name validations for POST /mdm/profiles endpoint (#17753)

7dcfef3

Follow up for #17402

Additional backend support for DDM profiles (#17775)

60ba78f

Merge branch 'main' into feat-macos-ddm

577d5c2

implement DDM cron and protocol bits (#17791)

95df7e2

for #17399

fix issues with ddm CLI (#17826)

44727ac

for #17404. I couldn't find tests for this portion of the code, so full tests for this section will need to be added during freeze.

implement status reports for DDM commands (#17831)

f0ad942

for #17408

add ddm activities to the UI (#17864)

bb63da4

relates to #17409 adds the ddm activities to the UI. - [x] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. - [x] Manual QA for all new/changed functionality

Update host details, list host filters, and MDM summary to include ma…

1edd9f0

…cOS declarations (#17866) Issue #17619 --------- Co-authored-by: Roberto Dip <dip.jesusr@gmail.com>

Add mdm_apple_declarative_requests table to log DDM requests (#17844)

7b13d9c

#17792

add ddm declarations in the API (#17880)

fdc5aa5

for #17409

batch set declarations as pending when they're uploaded (#17876)

0be9f08

#17685

Feat UI ddm integration (#17885)

88b6ac9

relate to #17416 update to uploading, downloading, and deleting ddm profiles. - [x] Manual QA for all new/changed functionality

add missing activities

15e671d

mna previously approved these changes Mar 27, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into feat-macos-ddm

e34b320

roperzh dismissed mna’s stale review via e34b320 March 27, 2024 14:58

roperzh temporarily deployed to Docker Hub March 27, 2024 14:58 — with GitHub Actions Inactive

mna previously approved these changes Mar 27, 2024

View reviewed changes

fix tests and lint

0d15132

roperzh dismissed mna’s stale review via 0d15132 March 27, 2024 15:21

roperzh had a problem deploying to Docker Hub March 27, 2024 15:21 — with GitHub Actions Error

Merge branch 'main' into feat-macos-ddm

94c55f9

roperzh temporarily deployed to Docker Hub March 27, 2024 15:22 — with GitHub Actions Inactive

mna marked this pull request as ready for review March 27, 2024 15:36

mna requested review from a team as code owners March 27, 2024 15:36

mna approved these changes Mar 27, 2024

View reviewed changes

gillespi314 approved these changes Mar 27, 2024

View reviewed changes

roperzh merged commit 087d758 into main Mar 27, 2024
24 checks passed

roperzh deleted the feat-macos-ddm branch March 27, 2024 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: macOS DDM support #17886

feat: macOS DDM support #17886

roperzh commented Mar 27, 2024 •

edited

codecov bot commented Mar 27, 2024 •

edited

feat: macOS DDM support #17886

feat: macOS DDM support #17886

Conversation

roperzh commented Mar 27, 2024 • edited

Checklist for submitter

codecov bot commented Mar 27, 2024 • edited

Codecov Report

roperzh commented Mar 27, 2024 •

edited

codecov bot commented Mar 27, 2024 •

edited