New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/fix/add tests for puppet-related flow (preassign+match) #17859
Update/fix/add tests for puppet-related flow (preassign+match) #17859
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat-prefill-account-name #17859 +/- ##
=============================================================
+ Coverage 65.64% 65.66% +0.01%
=============================================================
Files 1194 1194
Lines 108293 108272 -21
Branches 2574 2574
=============================================================
+ Hits 71094 71100 +6
+ Misses 31801 31782 -19
+ Partials 5398 5390 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also plan to adjust/add to the existing puppet-flow integration tests, but I'll do that in yet another PR as this one has non-test fixes that should be merged ASAP in the feature branch.
return ds, svc, ctx | ||
} | ||
|
||
func TestGetOrCreatePreassignTeam(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an existing test that was skipped due to the circular imports issue that is solved here via the external test approach (package service_test
), and the tests have been adjusted to the updated implementation using ApplyTeamSpec
.
Related to #17842.