Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/fix/add tests for puppet-related flow (preassign+match) #17859

Merged
merged 3 commits into from Mar 26, 2024

Conversation

mna
Copy link
Member

@mna mna commented Mar 26, 2024

Related to #17842.

  • Added/updated tests

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.66%. Comparing base (8253e77) to head (2cbbec0).
Report is 1 commits behind head on feat-prefill-account-name.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat-prefill-account-name   #17859      +/-   ##
=============================================================
+ Coverage                      65.64%   65.66%   +0.01%     
=============================================================
  Files                           1194     1194              
  Lines                         108293   108272      -21     
  Branches                        2574     2574              
=============================================================
+ Hits                           71094    71100       +6     
+ Misses                         31801    31782      -19     
+ Partials                        5398     5390       -8     
Flag Coverage Δ
backend 66.67% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@mna mna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also plan to adjust/add to the existing puppet-flow integration tests, but I'll do that in yet another PR as this one has non-test fixes that should be merged ASAP in the feature branch.

return ds, svc, ctx
}

func TestGetOrCreatePreassignTeam(t *testing.T) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an existing test that was skipped due to the circular imports issue that is solved here via the external test approach (package service_test), and the tests have been adjusted to the updated implementation using ApplyTeamSpec.

@mna mna marked this pull request as ready for review March 26, 2024 15:12
@mna mna requested a review from a team as a code owner March 26, 2024 15:12
@mna mna merged commit 74d60dc into feat-prefill-account-name Mar 26, 2024
18 checks passed
@mna mna deleted the mna-9147-add-puppet-related-tests branch March 26, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants