Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS OOBE Prefill and Lock Local Account: feature branch #17854

Merged
merged 12 commits into from Mar 27, 2024

Conversation

mna
Copy link
Member

@mna mna commented Mar 26, 2024

Feature branch for #9147 .

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 75.22659% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 65.36%. Comparing base (ea92433) to head (8abee3e).

Files Patch % Lines
server/worker/apple_mdm.go 67.93% 29 Missing and 13 partials ⚠️
frontend/services/entities/mdm.ts 0.00% 30 Missing ⚠️
...145650_UpdateDEPProfilesToAwaitDeviceConfigured.go 83.33% 6 Missing and 2 partials ⚠️
ee/server/service/mdm.go 95.45% 0 Missing and 1 partial ⚠️
frontend/components/FileUploader/FileUploader.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17854      +/-   ##
==========================================
- Coverage   65.39%   65.36%   -0.04%     
==========================================
  Files        1204     1206       +2     
  Lines      110008   110310     +302     
  Branches     2585     2592       +7     
==========================================
+ Hits        71943    72106     +163     
- Misses      32576    32691     +115     
- Partials     5489     5513      +24     
Flag Coverage Δ
backend 66.39% <82.77%> (-0.02%) ⬇️
frontend 51.28% <11.42%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

relates to #9147

add the setup assistant page to the UI. This includes:

- new setup assistant page
- uploaded profile and release device manually form
- preview for setup assistant flow

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Martin Angers <martin.n.angers@gmail.com>
@mna mna marked this pull request as ready for review March 26, 2024 18:01
roperzh
roperzh previously approved these changes Mar 27, 2024
Copy link
Member

@RachelElysia RachelElysia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved earlier this week on #17731, lgtm on this branch

@mna mna merged commit 79f9caf into main Mar 27, 2024
24 checks passed
@mna mna deleted the feat-prefill-account-name branch March 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants