Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with ddm CLI #17826

Merged
merged 4 commits into from Mar 25, 2024
Merged

fix issues with ddm CLI #17826

merged 4 commits into from Mar 25, 2024

Conversation

roperzh
Copy link
Member

@roperzh roperzh commented Mar 25, 2024

for #17404. I couldn't find tests for this portion of the code, so full tests for this section will need to be added during freeze.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feat-macos-ddm@577d5c2). Click here to learn what that means.

Files Patch % Lines
server/datastore/mysql/apple_mdm.go 67.64% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             feat-macos-ddm   #17826   +/-   ##
=================================================
  Coverage                  ?   65.85%           
=================================================
  Files                     ?     1194           
  Lines                     ?   109057           
  Branches                  ?     2574           
=================================================
  Hits                      ?    71820           
  Misses                    ?    31815           
  Partials                  ?     5422           
Flag Coverage Δ
backend 66.87% <70.27%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roperzh roperzh marked this pull request as ready for review March 25, 2024 15:49
@roperzh roperzh requested a review from a team as a code owner March 25, 2024 15:49
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@roperzh roperzh merged commit 44727ac into feat-macos-ddm Mar 25, 2024
18 checks passed
@roperzh roperzh deleted the ddm-cli branch March 25, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants