Return correct OS details for Windows Server 2019 #17760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
|
Fixed the os version-related issues, but it looks like the memory usage is a problem with osquery itself osquery/osquery#8059 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17760 +/- ##
==========================================
- Coverage 65.68% 65.61% -0.07%
==========================================
Files 1193 1193
Lines 108031 108031
Branches 2574 2574
==========================================
- Hits 70955 70883 -72
- Misses 31707 31766 +59
- Partials 5369 5382 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
|
The memory detection issue seems to be VM-related, I'm not going to pursue it further as part of this issue. If it comes up again on hardware I'll look deeper into it |
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
mna
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17562
changes/ororbit/changes/.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)Added/updated testsQuery was not returning results because of a select on a nonexistant row