New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfixes, integration and cleanup for DDM #17756
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-macos-ddm #17756 +/- ##
=================================================
Coverage ? 65.71%
=================================================
Files ? 1194
Lines ? 108888
Branches ? 2574
=================================================
Hits ? 71551
Misses ? 31907
Partials ? 5430
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
macos lint timed out as usual, merging. |
Improvements and fixes I found while integrating this
host_mdm_apple_declarations
team_declaration_checksum_view
MDMAppleRecordDeclarativeCheckIn
, I confused myself by developing this using tests, the device actually sends anAcknowledged
response, which is recorded by nanodeclaration/../..
endpointsdeclaration
withouts
ServerToken
, otherwise the declaration failsChecklist for submitter
If some of the following don't apply, delete the relevant line.
SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)