Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfixes, integration and cleanup for DDM #17756

Merged
merged 6 commits into from Mar 21, 2024
Merged

Conversation

roperzh
Copy link
Member

@roperzh roperzh commented Mar 21, 2024

Improvements and fixes I found while integrating this

  • Renamed db columns to match the profile tables for consistency
  • Added columns to host_mdm_apple_declarations
  • Removed team_declaration_checksum_view
  • Remove the ad-hoc MDMAppleRecordDeclarativeCheckIn, I confused myself by developing this using tests, the device actually sends an Acknowledged response, which is recorded by nano
  • Fixed bugs in the declaration/../.. endpoints
    • The prefix for the endpoint is declaration without s
    • The response needs to include a ServerToken, otherwise the declaration fails

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 86.81319% with 12 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feat-macos-ddm@7dcfef3). Click here to learn what that means.

Files Patch % Lines
...l/migrations/tables/20240314150853_AddDDMTables.go 80.00% 6 Missing ⚠️
server/service/apple_mdm.go 68.75% 4 Missing and 1 partial ⚠️
server/mock/datastore_mock.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             feat-macos-ddm   #17756   +/-   ##
=================================================
  Coverage                  ?   65.71%           
=================================================
  Files                     ?     1194           
  Lines                     ?   108888           
  Branches                  ?     2574           
=================================================
  Hits                      ?    71551           
  Misses                    ?    31907           
  Partials                  ?     5430           
Flag Coverage Δ
backend 66.71% <86.81%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roperzh roperzh marked this pull request as ready for review March 21, 2024 11:53
@roperzh roperzh requested a review from a team as a code owner March 21, 2024 11:53
server/service/apple_mdm.go Show resolved Hide resolved
server/service/integration_mdm_test.go Outdated Show resolved Hide resolved
server/service/integration_mdm_test.go Show resolved Hide resolved
server/service/integration_mdm_test.go Show resolved Hide resolved
@roperzh
Copy link
Member Author

roperzh commented Mar 21, 2024

macos lint timed out as usual, merging.

@roperzh roperzh merged commit 495638b into feat-macos-ddm Mar 21, 2024
16 of 17 checks passed
@roperzh roperzh deleted the ddm-cleanups branch March 21, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants