Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add schema for DDM #17636

Merged
merged 4 commits into from Mar 14, 2024
Merged

add schema for DDM #17636

merged 4 commits into from Mar 14, 2024

Conversation

roperzh
Copy link
Member

@roperzh roperzh commented Mar 14, 2024

#17405

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 84.76821% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 65.63%. Comparing base (01dfce5) to head (fe50879).
Report is 1 commits behind head on feat-macos-ddm.

Files Patch % Lines
...l/migrations/tables/20240314150853_AddDDMTables.go 84.76% 16 Missing and 7 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           feat-macos-ddm   #17636      +/-   ##
==================================================
+ Coverage           65.60%   65.63%   +0.02%     
==================================================
  Files                1193     1194       +1     
  Lines              108028   108179     +151     
  Branches             2574     2574              
==================================================
+ Hits                70875    71003     +128     
- Misses              31770    31786      +16     
- Partials             5383     5390       +7     
Flag Coverage Δ
backend 66.63% <84.76%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roperzh roperzh changed the base branch from main to feat-macos-ddm March 14, 2024 20:54
@roperzh roperzh marked this pull request as ready for review March 14, 2024 20:55
@roperzh roperzh requested a review from a team as a code owner March 14, 2024 20:55
Copy link
Contributor

@jahzielv jahzielv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send it!

@roperzh roperzh merged commit dc87ac2 into feat-macos-ddm Mar 14, 2024
13 checks passed
@roperzh roperzh deleted the 17405-db branch March 14, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants