prevent redundant ADE profile assignment #17427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #17291, this prevent re-assigning profiles to ABM hosts that already have the right one. This was happening very frequently for hosts that are in the last page of the `/sync` request, as there's no indication that the cursor was exhausted and we keept on assigning profiles to those hosts. This caused profile assignment to eventually fail, presumably due to rate limiting.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17427 +/- ##
=======================================
Coverage 65.50% 65.50%
=======================================
Files 1192 1192
Lines 107485 107489 +4
Branches 2565 2565
=======================================
+ Hits 70406 70411 +5
+ Misses 31711 31710 -1
Partials 5368 5368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gillespi314
approved these changes
Mar 6, 2024
| @@ -34,7 +34,6 @@ import ( | |||
| "github.com/fleetdm/fleet/v4/server/datastore/mysql" | |||
| "github.com/fleetdm/fleet/v4/server/datastore/redis/redistest" | |||
| "github.com/fleetdm/fleet/v4/server/fleet" | |||
| mdm_types "github.com/fleetdm/fleet/v4/server/fleet" | |||
There was a problem hiding this comment.
Weird, we were importing package fleet twice?
There was a problem hiding this comment.
yes 😂 , I noticed we do this in a couple of places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #17291, this prevent re-assigning profiles to ABM hosts that already have the right one.
This was happening very frequently for hosts that are in the last page of the
/syncrequest, as there's no indication that the cursor was exhausted and we keept on assigning profiles to those hosts.This caused profile assignment to eventually fail, presumably due to rate limiting.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/ororbit/changes/.See Changes files for more information.