fix: Catch connection initialization errors (#1043)

This catches database connection initialization errors. Fixes #1037
feathersjs · Oct 6, 2018 · 4f9acd6 · 4f9acd6
1 parent 0275722
commit 4f9acd6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/generator-feathers/generators/connection/templates/mongodb.js b/packages/generator-feathers/generators/connection/templates/mongodb.js
@@ -1,5 +1,6 @@
 const parse = require('mongodb-core').parseConnectionString;
 const MongoClient = require('mongodb').MongoClient;
+const logger = require('./logger');
 
 module.exports = function (app) {
   const config = app.get('mongodb');
@@ -11,6 +12,8 @@ module.exports = function (app) {
 
     const dbName = parse(config, () => {});
     return client.db(dbName);
+  }).catch(error => {
+    logger.error(error);
   });
 
   app.set('mongoClient', promise);

diff --git a/packages/generator-feathers/generators/connection/templates/rethinkdb.js b/packages/generator-feathers/generators/connection/templates/rethinkdb.js
@@ -1,4 +1,5 @@
 const rethinkdbdash = require('rethinkdbdash');
+const logger = require('./logger');
 
 module.exports = function (app) {
   const config = app.get('rethinkdb');
@@ -16,7 +17,11 @@ module.exports = function (app) {
       const service = app.service(path);
 
       if (typeof service.init === 'function') {
-        promise = promise.then(() => service.init());
+        promise = promise.then(() => {
+          service.init();
+        }).catch(error => {
+          logger.error(error);
+        });
       }
     });