Run onSend hooks when an encapsulated handler invokes the notFound handler #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Apr 1, 2018
lib/reply.js
Outdated
| reply.context = reply.context._404Context | ||
| reply.context.handler(reply.request, reply) | ||
| // Use a copy of the 404 context with the original context's onSend hooks | ||
| const context = Object.assign({}, reply.context._404Context) |
There was a problem hiding this comment.
Can you use prototypical inheritance here (Object.create..)? So that we avoid a full copy, the context is big and assign is slow.
lib/reply.js
Outdated
| // Use a copy of the 404 context with the original context's onSend hooks | ||
| const context = Object.assign({}, reply.context._404Context) | ||
| context.onSend = reply.context.onSend | ||
| reply.context = context |
There was a problem hiding this comment.
Can you make all this block optional, only if there are onSend hooks?
delvedor
approved these changes
Apr 1, 2018
There was a problem hiding this comment.
LGTM
Can you also upper case the F here?
Line 689 in b010287
In this way the message is the same as the spec.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a route is encapsulated, it may have more
onSendhooks than the notFound handler associated with the route. This PR makes sure that if a route invokes the notFound handler, all of the route'sonSendhooks will run.Fixes #868
Checklist
npm run testandnpm run benchmark