Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking to factory function options from Server Methods #819

Merged
merged 1 commit into from Mar 1, 2018

Conversation

jsumners
Copy link
Member

@jsumners jsumners commented Mar 1, 2018

Addresses the specific issue mentioned in #801.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added the documentation Improvements or additions to documentation label Mar 1, 2018
@jsumners jsumners merged commit 1b5e476 into master Mar 1, 2018
@jsumners jsumners deleted the docfix branch March 1, 2018 13:15
@lmammino
Copy link
Member

lmammino commented Mar 1, 2018

Unfortunately, this didn't fully fix the issue (check https://www.fastify.io/docs/latest/Server-Methods/). I'll open a dedicated issue on the website repo and try to troubleshoot it this weekend

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants