Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 4 is no more. #818

Merged
merged 2 commits into from Feb 28, 2018
Merged

Node 4 is no more. #818

merged 2 commits into from Feb 28, 2018

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Feb 28, 2018 •
edited

Fixes: #817.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@mcollina mcollina changed the title Node 4 is not more. Node 4 is no more. Feb 28, 2018
delvedor
delvedor reviewed Feb 28, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update also the package.json?

fastify/package.json

Lines 63 to 65 in 9cc9f35

"engines": {
"node": ">=4.5"
},

delvedor
delvedor approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added this to the v1.0.0 milestone Feb 28, 2018
jsumners
jsumners approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit eb24aa7 into master Feb 28, 2018
@mcollina mcollina deleted the node-four-no-more branch February 28, 2018 13:19
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2022
@Eomm Eomm added the semver-major Issue or PR that should land as semver major label Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
semver-major Issue or PR that should land as semver major
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcollina @jsumners @delvedor @Eomm