Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FastifyInstance::after typescript definition #814

Merged
merged 2 commits into from Feb 28, 2018
Merged

Add FastifyInstance::after typescript definition #814

merged 2 commits into from Feb 28, 2018

Conversation

jeromemacias
Copy link
Contributor

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

nwoltman
nwoltman reviewed Feb 27, 2018
View reviewed changes
fastify.d.ts Outdated
*/
after(afterListener?: (err: Error) => void): void
after(afterListener?: (err: Error, done: Function) => void): void
after(afterListener?: (err: Error, context: FastifyInstance<HttpServer, HttpRequest, HttpResponse>, done: Function) => void): void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the afterListener callback is optional there should be a test for that. I think it's required though so the ? would need to be removed.

mcollina
mcollina approved these changes Feb 27, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nwoltman
nwoltman approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@nwoltman nwoltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 9cc9f35 into fastify:master Feb 28, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2022
@jeromemacias jeromemacias deleted the ts_def_up branch February 18, 2022 16:09
@Eomm Eomm added the semver-minor Issue or PR that should land as semver minor label Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@nwoltman nwoltman nwoltman approved these changes

Assignees
No one assigned
Labels
semver-minor Issue or PR that should land as semver minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeromemacias @mcollina @nwoltman @delvedor @Eomm