Add fastify-favicon to community plugins list (#806)

[smartiniOnGitHub]

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

---

To ensure it really works (other than usual tests and example) I just used it in a sample webapp: fastify-example

[allevo]

Hi!

thank you!

Can you move this line to the top scope?

https://github.com/smartiniOnGitHub/fastify-favicon/blob/7d08d34613233941f585a566786178df37f4dc1e/plugin.js#L21-L23

The path can be calculated one time instead of each request

Anyway I don't know which licence is applied to the logo. @mcollina ?

[smartiniOnGitHub]

Hi @allevo , yes sure ... thanks for the hint :-) . I'll do today (and publish a new 0.1.2 plugin release in npmjs).
I discussed licensing of logo/favicon here, but if there is something to fix please tell me.

[jsumners]

@allevo https://github.com/smartiniOnGitHub/fastify-favicon/blob/7d08d34613233941f585a566786178df37f4dc1e/LICENSE#L205-L235

[smartiniOnGitHub]

@jsumners Hi, is there some problem with (original) favicon file (its license) put there ?
Note that other details are in the NOTICE file.

[jsumners]

@smartiniOnGitHub no, I was answering @allevo's question.

[smartiniOnGitHub]

Ah ok, thanks ... for sure I don't want problems with licensing :-) ...

[smartiniOnGitHub]

@allevo @jsumners ok, proposed changes just done in the plugin fastify-favicon and in its real usage test fastify-example , and uploaded a new plugin release in npmjs at fastify-favicon - npmjs .
Thanks a lot for the review and all suggestions :-) . Bye

[smartiniOnGitHub]

Hi all, any news on tis ? Thanks :-)

[allevo]

LGTM

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.