Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing printRoutes ts definition on FastifyInstance #798

Merged
merged 3 commits into from Feb 20, 2018
Merged

Add missing printRoutes ts definition on FastifyInstance #798

merged 3 commits into from Feb 20, 2018

Conversation

jeromemacias
Copy link
Contributor

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@jeromemacias jeromemacias changed the title Add missing printRoutes ts definition on FastofyInstance Add missing printRoutes ts definition on FastifyInstance Feb 19, 2018
nwoltman
nwoltman suggested changes Feb 19, 2018
View reviewed changes
fastify.d.ts Outdated
/**
* Prints the representation of the internal radix tree used by the router
*/
printRoutes(): String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use string with a lowercase s.
Reference: https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html

allevo
allevo reviewed Feb 19, 2018
View reviewed changes
Copy link
Member

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

@jeromemacias
Copy link
Contributor Author

@allevo Test added

allevo
allevo approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

nwoltman
nwoltman approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@nwoltman nwoltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allevo allevo merged commit a5a2592 into fastify:master Feb 20, 2018
@jeromemacias jeromemacias deleted the ts_def_up branch February 20, 2018 08:58
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@allevo allevo allevo approved these changes

@nwoltman nwoltman nwoltman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeromemacias @allevo @nwoltman