Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: fix req.hostname not set #2113

Merged
merged 2 commits into from Feb 24, 2020
Merged

http2: fix req.hostname not set #2113

merged 2 commits into from Feb 24, 2020

Conversation

mohd-akram
Copy link
Contributor

Fixes #2112

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • commit message and code follows Code of conduct

SerayaEryn
SerayaEryn approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@SerayaEryn SerayaEryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina reviewed Feb 24, 2020
View reviewed changes
lib/route.js Outdated Show resolved Hide resolved
@mohd-akram @mcollina
Update lib/route.js
378f9c4 
Co-Authored-By: Matteo Collina <matteo.collina@gmail.com>
mcollina
mcollina approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 093947b into fastify:master Feb 24, 2020
@mohd-akram mohd-akram deleted the fix-http2-hostname branch February 24, 2020 12:12
@Eomm Eomm added bugfix Issue or PR that should land as semver patch v2.x Issue or pr related to Fastify v2 labels Feb 24, 2020
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 29, 2020
Closed
This was referenced Apr 12, 2020
Merged
Merged
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@SerayaEryn SerayaEryn SerayaEryn approved these changes

Assignees
No one assigned
Labels
bugfix Issue or PR that should land as semver patch v2.x Issue or pr related to Fastify v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request.hostname isn't set when using HTTP2
4 participants
@mohd-akram @mcollina @SerayaEryn @Eomm