docs: use computed key when assigning property to request #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed this when reading through docs on plugins. I think the intention was for the util to be the same in every case, but in the first case it was assigning the value to the literal key property of request instead of the computed value of key using square brackets. Since it's the first example it confused me, but made since when I looked further down. ``` request.key = value request[key] = value ```
|
good spot! |
This was referenced Feb 20, 2020
This was referenced Apr 12, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this when reading through docs on plugins. I think the intention was for the util to be the same in every case, but in the first case it was assigning the value to the literal key property of request instead of the computed value of key using square brackets.
Since it's the first example it confused me, but made sense when I looked further down and noticed the second and third examples using square bracket notation. This makes them all the same.
Checklist
npm run testandnpm run benchmark