New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fastify-esso plugin #2084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would recommend to tone down the language in the README a bit.
By “tone down”, you mean I might have exaggerated in my claims or that I’ve used inappropriate language? Anyway, sorry about that. EDIT: I've updated it, making it more formal and also adding references that support my claims. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Phrases like this:
It's something you might say in front of a pint with a friend, not in a README of an OSS project. Again
Not something you'd like to read from a README. and many more |
Okay, advice taken. Hopefully I managed to fix it all. I was just trying to make it look cooler, but it seems it had the opposite effect. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As titled :)
This is yet another authentication plugin for Fastify, but its quite different from the others. I wrote some pretty decent docs that should help developers getting started with Fastify (and perhaps Node) to implement simple, but effective (and safe) authentication.
Thanks!
Checklist
npm run test
andnpm run benchmark