Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fastify-esso plugin #2084

Merged
merged 1 commit into from Feb 7, 2020
Merged

Added fastify-esso plugin #2084

merged 1 commit into from Feb 7, 2020

Conversation

patrickpissurno
Copy link
Contributor

@patrickpissurno patrickpissurno commented Feb 7, 2020

As titled :)

This is yet another authentication plugin for Fastify, but its quite different from the others. I wrote some pretty decent docs that should help developers getting started with Fastify (and perhaps Node) to implement simple, but effective (and safe) authentication.

Thanks!

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would recommend to tone down the language in the README a bit.

@patrickpissurno
Copy link
Contributor Author

patrickpissurno commented Feb 7, 2020

By “tone down”, you mean I might have exaggerated in my claims or that I’ve used inappropriate language?

Anyway, sorry about that.

EDIT: I've updated it, making it more formal and also adding references that support my claims.

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm Eomm added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Feb 7, 2020
@Eomm Eomm merged commit 1c52b9f into fastify:master Feb 7, 2020
@mcollina
Copy link
Member

mcollina commented Feb 7, 2020

Phrases like this:

It works in a quite similar way to JWTs, but cutting out the bullshit and providing data encryption (instead of simply signing it).

It's something you might say in front of a pint with a friend, not in a README of an OSS project.

Again

So yeah, this is fricking safe.

Not something you'd like to read from a README.

and many more

@patrickpissurno
Copy link
Contributor Author

Okay, advice taken. Hopefully I managed to fix it all. I was just trying to make it look cooler, but it seems it had the opposite effect.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants