Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update inject features #2029

Merged
merged 2 commits into from Jan 7, 2020
Merged

update inject features #2029

merged 2 commits into from Jan 7, 2020

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Jan 7, 2020

Follow up fastify/light-my-request#72

Updating light my request, we can use two new snippet:

  • cookies
  • res.json()

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@Eomm Eomm added the documentation Improvements or additions to documentation label Jan 7, 2020
mcollina
mcollina approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

delvedor
delvedor approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm Eomm merged commit d445474 into master Jan 7, 2020
@Eomm Eomm deleted the Eomm-patch-2 branch January 7, 2020 21:17
This was referenced Jan 10, 2020
Merged
Open
This was referenced Mar 20, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 29, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 12, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eomm @mcollina @delvedor