Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary condition #1505

Merged
merged 1 commit into from Mar 6, 2019
Merged

refactor: remove unnecessary condition #1505

merged 1 commit into from Mar 6, 2019

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Mar 5, 2019 •
edited

Remove the condition check which is always true

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

delvedor
delvedor approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added the internals Change that won't impact the surface API. label Mar 5, 2019
mcollina
mcollina approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cemremengu
cemremengu reviewed Mar 5, 2019
View reviewed changes
Copy link
Contributor

@cemremengu cemremengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delvedor === true for micro optimisation? :)

@mcollina
Copy link
Member

mcollina commented Mar 6, 2019

Not really, this is just a leftover from refactoring.

@mcollina mcollina merged commit b2bdfee into fastify:master Mar 6, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cemremengu cemremengu cemremengu left review comments

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
internals Change that won't impact the surface API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clarkdo @mcollina @cemremengu @delvedor