Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fastify-405 plugin #1501

Merged
merged 1 commit into from Mar 2, 2019
Merged

add fastify-405 plugin #1501

merged 1 commit into from Mar 2, 2019

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Mar 2, 2019

Hi, I would like to add my plugin to the ecosystem

This plugin tries to solve issue #917

Checklist

  • run npm run test and npm run benchmark
  • tests the and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@mcollina
Copy link
Member

mcollina commented Mar 2, 2019

I would just add Travis or another CI system to the module. Good work!

@Eomm Eomm mentioned this pull request Mar 2, 2019
Merged
@Eomm
Copy link
Member Author

Eomm commented Mar 2, 2019

Good suggestion applied ✌
Thank you 🎉

mcollina
mcollina approved these changes Mar 2, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 563926f into fastify:master Mar 2, 2019
@delvedor delvedor added documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin. labels Mar 3, 2019
@delvedor delvedor mentioned this pull request Mar 3, 2019
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation plugin Identify a pr to the doc that adds a plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eomm @mcollina @delvedor