Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps #1493

Merged
merged 1 commit into from Feb 28, 2019
Merged

Update deps #1493

merged 1 commit into from Feb 28, 2019

Conversation

mcollina
Copy link
Member

This test was passing in a function as the second parameter. This function has not been called for a long time, and it conflicted with a new change in avvio@6.1.0.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • commit message and code follows Code of conduct

delvedor
delvedor approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added the chore Small changes or internal project maintenance label Feb 28, 2019
@mcollina mcollina merged commit c24b14a into master Feb 28, 2019
@mcollina mcollina deleted the fix-broken-deps branch February 28, 2019 18:32
@Ethan-Arrowood Ethan-Arrowood mentioned this pull request Feb 28, 2019
Closed
4 tasks
@mcollina mcollina mentioned this pull request Mar 5, 2019
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
chore Small changes or internal project maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcollina @delvedor