New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/fluent schema #1485
Docs/fluent schema #1485
Conversation
I truly don't like: const bodyJsonSchema = { ...S.object().valueOf(), vacation: 'sharedAddress#' } Is there a way around this? The reason why this is needed must be in the docs. Can you add some unit tests for the examples? |
It could be changed to a simply JSON: {
type: 'object',
properties: {
vacation: 'sharedAddress#'
}
}
Could I add a reference to Validation-and-Serialization.md?
Sure |
THat's better yes.
yes of course. |
@mcollina It seems that fluent-schema doesn't work with node 6. here the output What do you suggest to solve? |
skip the tests on Node 6. |
Simple but effective 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff here @Eomm! A couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #1329
I open this PR to get some feedback for this document and what examples I could add more.
Note that this line:
is necessary because the JSON schema standard (and
fluent-schema
too) doesn't provide support for a JSON like this:Checklist
npm run test
andnpm run benchmark