Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated LTS.md #1477

Merged
merged 1 commit into from Feb 25, 2019
Merged

Updated LTS.md #1477

merged 1 commit into from Feb 25, 2019

Conversation

delvedor
Copy link
Member

As titled 馃殌

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@delvedor delvedor added the documentation Improvements or additions to documentation label Feb 25, 2019
@delvedor delvedor requested a review from a team February 25, 2019 14:13
jsumners
jsumners approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Technically, the doc says a month is "30 days". So the real expire date would be 2019-08-24. But no one is going to complain about more support time.

mcollina
mcollina approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor
Copy link
Member Author

Technically, the doc says a month is "30 days". So the real expire date would be 2019-08-24. But no one is going to complain about more support time.

True, but also "sharp" dates are nicer and easy to remember :D

@delvedor delvedor merged commit 956c593 into master Feb 25, 2019
@delvedor delvedor deleted the update-lts-doc branch February 25, 2019 14:32
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delvedor @mcollina @jsumners