Add test for content-type overriding inside a plugin #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemremengu
suggested changes
Feb 5, 2019
|
Sure, np :) We'd like to patch our server for the proto poisoning asap, so if you have any advice on how to fix that regression, I'll gladly take it :) |
|
@Marsup you’ll need to pass along the kDefaultJSONParser property in the buildContentParser function at the end of the file. That should do the trick. |
|
@mcollina Would my last commit do the trick? |
|
Yes! |
Sorry about that! @mcollina should we apply this change also in |
cemremengu
approved these changes
Feb 5, 2019
Yes. |
mcollina
pushed a commit
that referenced
this pull request
Feb 5, 2019
* Add test for content-type overriding inside a plugin * Copy default JSON parser from previous content type parser
delvedor
pushed a commit
that referenced
this pull request
Feb 5, 2019
delvedor
added
bugfix
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkLatest minor broke our server, since it now generates new parser functions every time, the hasParser comparison fails. I only included a unit test so far to show the problem, I don't know how you want to address it so I'd happily take guidance on this one and make the changes, or feel free to merge the failing test and fix it if it's faster for you.