Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting multiple cookies as multiple 'Set-Cookie' headers. (fix h… #1360

Merged
merged 1 commit into from Jan 3, 2019
Merged

Fix setting multiple cookies as multiple 'Set-Cookie' headers. (fix h… #1360

merged 1 commit into from Jan 3, 2019

Conversation

digrich
Copy link
Contributor

@digrich digrich commented Jan 3, 2019

…ttps://github.com//issues/1358)

Fixes: #1358

Checklist

  • [ x ] run npm run test and npm run benchmark
  • [ x ] tests and/or benchmarks are included
  • documentation is changed or added
  • [ x ] commit message and code follows Code of conduct

mcollina
mcollina approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

delvedor
delvedor approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added the bugfix Issue or PR that should land as semver patch label Jan 3, 2019
@mcollina mcollina merged commit d7238f3 into fastify:1.x Jan 3, 2019
jsumners
jsumners reviewed Jan 3, 2019
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners left review comments

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
bugfix Issue or PR that should land as semver patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@digrich @mcollina @jsumners @delvedor