New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #1353 ignore evaluation of $schema field in json-schema #1354
Conversation
Thanks for the PR! Yes, the schemas are precompiled for efficiency (fastify's secret sauce) and we will need to backport this for 1.x as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backported to |
Thank you guys 馃槂 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi,
this is the fix for #1353 issue, where
$schema
field is ignored and it is notresolve
d.I checked that there aren't other fields like that, and I didn't notice them.
I have run also benchmark (with some problems 馃槄), but looking the code I think that this change impact only the startup time right?
Do you need this fix starting from branch
1.x
also?Thank you
Checklist
npm run test
andnpm run benchmark
Running banchmarks I get these error after some succesfull run, but maybe could be caused by PC?