Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override address in listen instead of listenPromise #1102

Merged
merged 1 commit into from Aug 26, 2018
Merged

Override address in listen instead of listenPromise #1102

merged 1 commit into from Aug 26, 2018

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 26, 2018

Fixes: #1099

Checklist

@trivikr trivikr mentioned this pull request Aug 26, 2018
Closed
mcollina
mcollina approved these changes Aug 26, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsumners
jsumners approved these changes Aug 26, 2018
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit acf3950 into fastify:master Aug 26, 2018
@delvedor delvedor added the internals Change that won't impact the surface API. label Aug 27, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
internals Change that won't impact the surface API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suspected dead code in listenPromise
4 participants
@trivikr @mcollina @jsumners @delvedor