Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Server-Methods into Factory #1101

Merged
merged 3 commits into from Aug 26, 2018
Merged

Move Server-Methods into Factory #1101

merged 3 commits into from Aug 26, 2018

Conversation

allevo
Copy link
Member

@allevo allevo commented Aug 26, 2018

Fix #1057 merge Server-Methods.md and Factory.md to Server.md

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@lmammino does this break the website?

delvedor
delvedor reviewed Aug 26, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must also update the README and the website should be ok :)

@delvedor delvedor added the documentation Improvements or additions to documentation label Aug 26, 2018
@allevo
Copy link
Member Author

allevo commented Aug 26, 2018

Updated

mcollina
mcollina approved these changes Aug 26, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsumners
jsumners approved these changes Aug 26, 2018
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit e6bca66 into fastify:master Aug 26, 2018
@fralonra fralonra mentioned this pull request Aug 27, 2018
Open
21 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvedor delvedor delvedor left review comments

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@allevo @mcollina @jsumners @delvedor