Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that error-in-post test is run #1096

Merged
merged 2 commits into from Aug 25, 2018
Merged

Ensure that error-in-post test is run #1096

merged 2 commits into from Aug 25, 2018

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 25, 2018

The test error-in-post was added in commit 01f1039, but it was never run as file didn't end with .test.js. Also, it isn't called from other test files.
This code change changes file extension to .test.js so that it's run

The output of npm run test before the code change:

...
test/delete.test.js ................................. 43/43
test/fastify-instance.test.js ......................... 1/1
...

after the code change:

...
test/delete.test.js ................................. 43/43
test/error-in-post.test.js ............................ 2/2
test/fastify-instance.test.js ......................... 1/1
...

Checklist

  • run npm run test and npm run benchmark
  • commit message and code follows Code of conduct

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

I'm not sure why that test fails on Windows.

Can you try adding a t.plan(1) and remove the 'beforeExit check?

@trivikr
Copy link
Member Author

trivikr commented Aug 25, 2018

Added t.plan(1) and removed beforeExit check as per #1096 (comment)

@mcollina mcollina merged commit 6bce249 into fastify:master Aug 25, 2018
@mcollina
Copy link
Member

Thanks!!

@trivikr trivikr deleted the error-in-post branch August 25, 2018 19:31
@delvedor delvedor added the internals Change that won't impact the surface API. label Aug 26, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
internals Change that won't impact the surface API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants