Rename and call unknown method tests from http2 #1095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for unknown method in http2 was added in #883, but it was never called as the file name didn't end with
.test.js
Also there was a typo in the file name
unknwon-http-method.js
This code change corrects the typo in the file name, and calls it from
http2.test.js
The output of the command
tap test/http2/http2.test.js
before the code change:After the code change:
Checklist
npm run test
andnpm run benchmark