Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and call unknown method tests from http2 #1095

Merged
merged 1 commit into from Aug 25, 2018
Merged

Rename and call unknown method tests from http2 #1095

merged 1 commit into from Aug 25, 2018

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 25, 2018

The test for unknown method in http2 was added in #883, but it was never called as the file name didn't end with .test.js
Also there was a typo in the file name unknwon-http-method.js

This code change corrects the typo in the file name, and calls it from http2.test.js

The output of the command tap test/http2/http2.test.js before the code change:

test/http2/http2.test.js ..(node:2557) ExperimentalWarning: The http2 module is an experimental API.
test/http2/http2.test.js ............................ 24/24
total ............................................... 24/24

  24 passing (393.96ms)

  ok

After the code change:

test/http2/http2.test.js ...(node:2591) ExperimentalWarning: The http2 module is an experimental API.
test/http2/http2.test.js ............................ 28/28
total ............................................... 28/28

  28 passing (414.795ms)

  ok

Checklist

  • run npm run test and npm run benchmark
  • commit message and code follows Code of conduct

Copy link
Member

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 3895a75 into fastify:master Aug 25, 2018
@mcollina
Copy link
Member

Thanks!!

@trivikr trivikr deleted the unknown-http-method branch August 25, 2018 18:26
@delvedor delvedor added the internals Change that won't impact the surface API. label Aug 26, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
internals Change that won't impact the surface API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants