Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pluginTimeout option. #1088

Merged
merged 1 commit into from Aug 24, 2018
Merged

Added pluginTimeout option. #1088

merged 1 commit into from Aug 24, 2018

Conversation

mcollina
Copy link
Member

I've seen some people complaining that debugging what plugin did not start is very hard.
This fixed it by adding a pluginTimeout option to Fastify, the errors will contain the name of the plugin as guessed by avvio.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@mcollina mcollina requested a review from delvedor August 24, 2018 12:03
delvedor
delvedor approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added the semver-minor Issue or PR that should land as semver minor label Aug 24, 2018
@delvedor
Copy link
Member

As discussed in a private conversation, in the next major version of Fastify we should add a default timeout that is not 0.

allevo
allevo approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 50bcf6b into master Aug 24, 2018
@fralonra fralonra mentioned this pull request Aug 25, 2018
Open
21 tasks
@delvedor delvedor deleted the plugin-timeout branch August 25, 2018 08:40
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@allevo allevo allevo approved these changes

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
semver-minor Issue or PR that should land as semver minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcollina @delvedor @allevo