JSON Schema Error: missing id schema when set $schema

[Eomm]

🐛 Bug Report

I'm working on issue 1329 and so I'm trying the docs I'm writing, but I got this error when using the following schema:

{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "properties": {
    "someKey": {
      "type": "string"
    }
  }
}

Error:
FastifyError [FST_ERR_SCH_NOT_PRESENT]: FST_ERR_SCH_NOT_PRESENT: Schema with id 'http://json-schema.org/draft-07/schema' does not exist!
    at Schemas.resolve (C:\Users\behem\workspace\fastify\lib\schemas.js:30:11)
    at Schemas.traverse (C:\Users\behem\workspace\fastify\lib\schemas.js:76:26)
    at Schemas.traverse (C:\Users\behem\workspace\fastify\lib\schemas.js:80:12)
    at Schemas.resolveRefs (C:\Users\behem\workspace\fastify\lib\schemas.js:49:10)
    at build (C:\Users\behem\workspace\fastify\lib\validation.js:29:28)
    at afterRouteAdded (C:\Users\behem\workspace\fastify\fastify.js:636:9)
    at C:\Users\behem\workspace\fastify\fastify.js:596:7

To Reproduce

const fastify = require('fastify')({ logger: true })
const { FluentSchema } = require('fluent-schema')

const bodySchema = FluentSchema()
  .prop(
    'someKey',
    FluentSchema()
      .asString()
  )

const schema = { body: bodySchema.valueOf() }

fastify.post('/the/url', { schema }, (request, reply) => {
  reply.send({ hello: 'world' })
})

fastify.listen(3000, (err, address) => {
  if (err) throw err
  fastify.log.info(`server listening on ${address}`)
})

Expected behavior

I don't expect the thrown's error. The $schema is raccomended by the standard so, maybe I'm missing something or this field should be ignored?

If I remove the $schema field, all is working:

delete schema.body.$schema

Your Environment

• node version: 8.14.0
• fastify version: 2.0.0-rc.3
• os: Windows 10
• fluent-schema: 0.4.0

[mcollina]

This is actually a bug in fastify! Good spot.

I think $schema must be ignored in

fastify/lib/schemas.js

Line 75 in a584210

if (typeof schema[key] === 'string' && schema[key].slice(-1) === '#') {

. Would you like to send a PR for this as well?

[mcollina]

I've moved this issue from fastify/help  to fastify/fastify  as it's actually a bug.

[Eomm]

Would you like to send a PR for this as well?

Sure!