Skip to content

Commit

Permalink
Add listen notice for GCP (#1264)
Browse files Browse the repository at this point in the history
* Update README.md

Per #1263 . This question has come up multiple times so I think adding a note can be helpful.

* Flip the sentence

* Update to include security risks and links

* Emphasize the notes section
  • Loading branch information
cemremengu authored and mcollina committed Nov 23, 2018
1 parent e901ff5 commit ec4f0a1
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions README.md
Expand Up @@ -102,10 +102,9 @@ fastify generate

For more information, see the [Fastify CLI documentation](https://github.com/fastify/fastify-cli).

#### Note

`.listen` binds to the local host, `localhost`, interface by default (`127.0.0.1` or `::1`, depending on the operating system configuration).
See [the documentation](https://github.com/fastify/fastify/blob/master/docs/Server.md#listen) for more information.
> ## Note
> `.listen` binds to the local host, `localhost`, interface by default (`127.0.0.1` or `::1`, depending on the operating system configuration). If you are running Fastify in a container (Docker, [GCP](https://cloud.google.com/), etc.), you may need to bind to `0.0.0.0`. Be careful when deciding to listen on all interfaces; it comes with inherent [security risks](https://web.archive.org/web/20170711105010/https://snyk.io/blog/mongodb-hack-and-secure-defaults/).
> See [the documentation](https://github.com/fastify/fastify/blob/master/docs/Server.md#listen) for more information.
### Core features

Expand Down

0 comments on commit ec4f0a1

Please sign in to comment.