Fixes validation when using shared schemas #226
Conversation
| @@ -202,7 +204,13 @@ function consumesFormOnly (schema) { | |||
| ) | |||
| } | |||
|
|
|||
| function getQueryParams (parameters, query) { | |||
| function getQueryParams (parameters, query, fastifySchemas) { | |||
| if (typeof query === 'string' && query.match(/#$/)) { | |||
There was a problem hiding this comment.
Would we have this problem also for the body if it is a string?
There was a problem hiding this comment.
Yes, it will be the problem with body, params, headers and all the stuff that accepts schemas as references.
This issue actually Fastify's regression fastify/fastify#2104
| @@ -5,6 +5,8 @@ const path = require('path') | |||
| const yaml = require('js-yaml') | |||
|
|
|||
| module.exports = function (fastify, opts, next) { | |||
| const fastifySchemas = fastify.getSchemas() | |||
There was a problem hiding this comment.
I have some concerns about using fastify.getSchemas(), cause they will return schemes only from "current" scope. So in this fix will only support those schemes which are defined through fastify plugin.
In order to support all cases you'll probably need to get them recursively from all contexts. See https://github.com/SkeLLLa/fastify-oas/blob/master/lib/openapi/index.js#L5 for example.
|
I think this issue was resolved in fastify/fastify#2108. |
It checks if
querystringis a string rather than an object, then finds the related fastify schema (if exists), and use that object to generate swagger doc.Fixes: #224
Checklist
npm run testandnpm run benchmark