Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent performance regression in DEV due to warning arguments #7461

Merged
merged 2 commits into from
Aug 10, 2016
Merged

Prevent performance regression in DEV due to warning arguments #7461

merged 2 commits into from
Aug 10, 2016

Commits on Aug 10, 2016

  1. Prevent internal performance regression 

    This only affects Facebook website, not open source version of React.

On the Facebook website, we don't have a transform for warnings and invariants.
Therefore, expensive arguments will be calculated even if the warning doesn't fire.
This fixes a few cases where that calculation might be more expensive than usually.

In my testing, this brings down average row click time in Power Editor from ~300ms to ~220ms in __DEV__ (vs ~40ms in prod).
    @gaearon
    gaearon committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    b5b8afd View commit details
    Browse the repository at this point in the history

  2. Put warning() that shows up in profile behind condition

    @gaearon
    gaearon committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    9530509 View commit details
    Browse the repository at this point in the history