[scheduler] Deadline object -> shouldYield #14025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a requestIdleCallback-style deadline object, expose a method Scheduler.shouldYield that returns true if there's a higher priority event in the queue.
|
React: size: -1.4%, gzip: -0.6% ReactDOM: size: -0.1%, gzip: -0.0% Details of bundled changes.Comparing: 21a79a1...55da990 react
react-dom
react-test-renderer
react-reconciler
react-art
react-native-renderer
scheduler
Generated by 🚫 dangerJS |
bvaughn
approved these changes
Oct 30, 2018
| function shouldYield() { | ||
| if ( | ||
| scheduledCallbackTimeout === -1 || | ||
| elapsedTimeInMs > scheduledCallbackTimeout |
There was a problem hiding this comment.
It's early and I'm probably being stupid, but shouldn't this be elapsedTimeInMs < scheduledCallbackTimeout ?
Edit Never mind. This is just saying that we should never yield if work has already timed out.
|
|
||
| function performAsyncWork() { | ||
| try { | ||
| if (!shouldYieldToRenderer()) { |
There was a problem hiding this comment.
It's not initially obvious to me that dl.didTimeout is semantically equivalent to shouldYieldToRenderer() but I trust you here.
| ) { | ||
| performWorkOnRoot( | ||
| nextFlushedRoot, | ||
| nextFlushedExpirationTime, | ||
| currentRendererTime >= nextFlushedExpirationTime, | ||
| !(currentRendererTime >= nextFlushedExpirationTime), |
There was a problem hiding this comment.
Uh, why ! >= rather than <?
There was a problem hiding this comment.
Planned to change it once I proved it worked, then forgot :D
| expectedNumberOfYields !== -1 && | ||
| yieldedValues.length >= expectedNumberOfYields | ||
| ) { | ||
| // We at least as many values as expected. Stop rendering. |
There was a problem hiding this comment.
"We yielded at least as many"?
This was referenced Nov 7, 2018
This was referenced Dec 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* [scheduler] Deadline object -> shouldYield Instead of using a requestIdleCallback-style deadline object, expose a method Scheduler.shouldYield that returns true if there's a higher priority event in the queue. * Nits
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* [scheduler] Deadline object -> shouldYield Instead of using a requestIdleCallback-style deadline object, expose a method Scheduler.shouldYield that returns true if there's a higher priority event in the queue. * Nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a requestIdleCallback-style deadline object, expose a method Scheduler.shouldYield that returns true if there's a higher priority event in the queue.