Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fire getDerivedStateFromProps unless props or state have changed #12802

Merged
merged 1 commit into from May 14, 2018
Merged

Do not fire getDerivedStateFromProps unless props or state have changed #12802

merged 1 commit into from May 14, 2018

Commits on May 14, 2018

  1. Do not fire getDerivedStateFromProps unless props or state have changed 

    Fixes an oversight from facebook#12600. getDerivedStateFromProps should fire
if either props *or* state have changed, but not if *neither* have
changed. This prevents a parent from re-rendering if a deep child
receives an update.
    @acdlite
    acdlite committed May 14, 2018
    Configuration menu
    Copy the full SHA
    ddbfffe View commit details
    Browse the repository at this point in the history