Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve host configs at build time #12792

Merged
merged 15 commits into from
May 19, 2018
Merged

Resolve host configs at build time #12792

merged 15 commits into from
May 19, 2018

Commits on May 18, 2018

  1. Extract base Jest config 

    This makes it easier to change the source config without affecting the build test config.
    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    a6ac452 View commit details
    Browse the repository at this point in the history

  2. Statically import the host config 

    This changes react-reconciler to import HostConfig instead of getting it through a function argument.

Rather than start with packages like ReactDOM that want to inline it, I started with React Noop and ensured that *custom* renderers using react-reconciler package still work. To do this, I'm making HostConfig module in the reconciler look at a global variable by default (which, in case of the react-reconciler npm package, ends up being the host config argument in the top-level scope).

This is still very broken.
    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    fe59043 View commit details
    Browse the repository at this point in the history

  3. Add scaffolding for importing an inlined renderer

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    cb2548e View commit details
    Browse the repository at this point in the history

  4. Fix the build

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    f17323b View commit details
    Browse the repository at this point in the history

  5. ES exports for renderer methods

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    21a2916 View commit details
    Browse the repository at this point in the history

  6. ES modules for host configs

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    1ea7e4d View commit details
    Browse the repository at this point in the history

  7. Remove closures from the reconciler

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    d292923 View commit details
    Browse the repository at this point in the history

  8. Check each renderer's config with Flow

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    265ba23 View commit details
    Browse the repository at this point in the history

  9. Fix uncovered Flow issue 

    We know nextHydratableInstance doesn't get mutated inside this function, but Flow doesn't so it thinks it may be null.
Help Flow.
    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    6037625 View commit details
    Browse the repository at this point in the history

  10. Prettier

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    a501c8b View commit details
    Browse the repository at this point in the history

  11. Get rid of enable*Reconciler flags 

    They are not as useful anymore because for almost all cases (except third party renderers) we *know* whether it supports mutation or persistence.

This refactoring means react-reconciler and react-reconciler/persistent third-party packages now ship the same thing.
Not ideal, but this seems worth how simpler the code becomes. We can later look into addressing it by having a single toggle instead.
    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    a1b7241 View commit details
    Browse the repository at this point in the history

  12. Prettier again

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    7d7981f View commit details
    Browse the repository at this point in the history

  13. Fix Flow config creation issue

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    e6410f9 View commit details
    Browse the repository at this point in the history

  14. Fix imprecise Flow typing

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    bdcc773 View commit details
    Browse the repository at this point in the history

  15. Revert accidental changes

    @gaearon
    gaearon committed May 18, 2018
    Configuration menu
    Copy the full SHA
    56ca671 View commit details
    Browse the repository at this point in the history