Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShallowRenderer should filter context by contextTypes #11922

Merged
merged 1 commit into from Jan 5, 2018
Merged

ShallowRenderer should filter context by contextTypes #11922

merged 1 commit into from Jan 5, 2018

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Dec 26, 2017

Fix #11862

gaearon
gaearon approved these changes Jan 5, 2018
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me

@gaearon gaearon merged commit 9d310e0 into facebook:master Jan 5, 2018
@koba04
Copy link
Contributor Author

koba04 commented Jan 6, 2018

Thanks!

@koba04 koba04 deleted the shallow-renderer-mask-context branch January 6, 2018 00:09
yenshih pushed a commit to yenshih/react that referenced this pull request Jan 6, 2018
@koba04 @yenshih
ShallowRenderer should filter context by contextTypes (facebook#11922)
3846d7b
ManasJayanth pushed a commit to ManasJayanth/react that referenced this pull request Jan 12, 2018
@koba04 @ManasJayanth
ShallowRenderer should filter context by contextTypes (facebook#11922)
b8a7b65
@gaearon gaearon mentioned this pull request Mar 29, 2018
Merged
This was referenced Mar 30, 2018
Closed
Closed
Open
Closed
Open
Closed
Open
Open
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
@dependencies dependencies bot mentioned this pull request Apr 2, 2018
Closed
@minznerjosh minznerjosh mentioned this pull request Jan 7, 2019
Closed
10 tasks
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
@koba04 @gaearon
ShallowRenderer should filter context by contextTypes (#11922)
c8ee18f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@koba04 @gaearon @facebook-github-bot