Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check to deduplicate function type warning calls on each compon… #11120

Merged
merged 4 commits into from Oct 6, 2017
Merged

Added check to deduplicate function type warning calls on each compon… #11120

merged 4 commits into from Oct 6, 2017

Conversation

andreysaleba
Copy link

@andreysaleba andreysaleba commented Oct 5, 2017

Hey, I've added check to avoid duplication of messages 'Functions are not valid as React child...' for same component type.

Also, this is my first PR in React, yay.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@andreysaleba
Copy link
Author

Hmm, I've completed the CLA.

@andreysaleba
Copy link
Author

#11086

@reactjs-bot
Copy link

reactjs-bot commented Oct 5, 2017

Deploy preview ready!

Built with commit 5852b59

https://deploy-preview-11120--reactjs.netlify.com

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Oct 5, 2017

Can you please test it too? You can take the existing test for it, expand it to render two times and in two places, and then verify that we only saw 2 logs (rather than 4).

@andreysaleba
Copy link
Author

Sure, I'll update it soon

@andreysaleba
Copy link
Author

andreysaleba commented Oct 6, 2017

I've added test checking deduplication of warning.

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this tests deduplication. You'd need to render twice to verify it works.

… React child' warning so it will check against rerendering component now
@andreysaleba
Copy link
Author

Yeah, my bad, sorry.

I've added rendering of component twice to the test.

@gaearon
Copy link
Collaborator

gaearon commented Oct 6, 2017

Looks great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants