Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReactDOMNodeStream, adding streaming rendering. #10024

Merged
merged 17 commits into from
Jun 25, 2017
Merged

Add ReactDOMNodeStream, adding streaming rendering. #10024

merged 17 commits into from
Jun 25, 2017

Commits on Jun 22, 2017

  1. Add ReactDOMNodeStream, adding ability to stream generated HTML.

    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    6f58bd8 View commit details
    Browse the repository at this point in the history

  2. Forgot to rename a documentation page.

    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    946f99b View commit details
    Browse the repository at this point in the history

  3. Tests are passing locally but failing on CI; attempt to fix that with… 

    … this tweak.
    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    12192cc View commit details
    Browse the repository at this point in the history

  4. Adding some debugging info to try to track down CI problem.

    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    85144e5 View commit details
    Browse the repository at this point in the history

  5. More debugging of CI. Yay for printf debugging.

    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    b0bef41 View commit details
    Browse the repository at this point in the history

  6. More printf debugging of CI to figure out what is going on with inclu… 

    …des during tests.
    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    adb3e59 View commit details
    Browse the repository at this point in the history

  7. I made a truly stupid error with my printf debugging statements for C… 

    …I. Fixing that.
    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    ee6e233 View commit details
    Browse the repository at this point in the history

  8. And another dumb copy and paste typo.

    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    f9b3f79 View commit details
    Browse the repository at this point in the history

  9. The node-stream.js stub for tests wasn't being added because of .giti… 

    …gnore.
    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    8386fd3 View commit details
    Browse the repository at this point in the history

  10. Fix for code review coment facebook#10024 (comment) . Thanks to @razh … 

    …for helping me out.
    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    132567d View commit details
    Browse the repository at this point in the history

  11. Removing all the console.logs I put in to debug the build problems on… 

    … the CI server.
    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    af4e89c View commit details
    Browse the repository at this point in the history

  12. Fix for code review coment facebook#10024 (comment) . Thanks to @aweary… 

    … for the suggestion.
    @aickin
    aickin committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    b8f2529 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2017

  1. Response to code review comment facebook#10024 (comment) . Thanks, @g… 

    …aearon.
    @aickin
    aickin committed Jun 23, 2017
    Configuration menu
    Copy the full SHA
    b6f9e06 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2017

  1. Responding to code comments facebook#10024 (review) , facebook#10024 … 

    …(review) , and facebook#10024 (review) . Thanks to @sebmarkbage for the help.
    @aickin
    aickin committed Jun 24, 2017
    Configuration menu
    Copy the full SHA
    3d1421a View commit details
    Browse the repository at this point in the history

  2. Attempt to tweak spacing to see if it makes the prettier build step h… 

    …appy.
    @aickin
    aickin committed Jun 24, 2017
    Configuration menu
    Copy the full SHA
    8c3c5c7 View commit details
    Browse the repository at this point in the history

  3. Found a prettier bug that wasn't being reported by npm run prettier f… 

    …or some reason.
    @aickin
    aickin committed Jun 24, 2017
    Configuration menu
    Copy the full SHA
    66b4e0f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2017

  1. Fixed a small prettier issue

    @aickin
    aickin committed Jun 25, 2017
    Configuration menu
    Copy the full SHA
    28c6bcc View commit details
    Browse the repository at this point in the history