Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

fix: add missing TSSymbolKeyword type #385

Merged
merged 1 commit into from Sep 25, 2017

Conversation

ikatyang
Copy link
Contributor

@jsf-clabot
Copy link

jsf-clabot commented Sep 18, 2017

CLA assistant check
All committers have signed the CLA.

@azz
Copy link
Contributor

azz commented Sep 18, 2017

I added never in #381, I wonder if there's more.

@j-f1
Copy link
Contributor

j-f1 commented Sep 18, 2017

@azz Of the *Keyword nodes, these ones are missing:

There’s lots 🙁
TSAsKeyword
TSAwaitKeyword
TSBreakKeyword
TSCaseKeyword
TSCatchKeyword
TSClassKeyword
TSConstKeyword
TSConstructorKeyword
TSContinueKeyword
TSDebuggerKeyword
TSDefaultKeyword
TSDeleteKeyword
TSDoKeyword
TSElseKeyword
TSEnumKeyword
TSExtendsKeyword
TSFalseKeyword
TSFinallyKeyword
TSFirstKeyword
TSForKeyword
TSFromKeyword
TSFunctionKeyword
TSGetKeyword
TSGlobalKeyword
TSIfKeyword
TSImplementsKeyword
TSImportKeyword
TSInKeyword
TSInstanceOfKeyword
TSInterfaceKeyword
TSIsKeyword
TSKeyOfKeyword
TSLastKeyword
TSLetKeyword
TSModuleKeyword
TSNamespaceKeyword
TSNewKeyword
TSOfKeyword
TSPackageKeyword
TSRequireKeyword
TSReturnKeyword
TSSetKeyword
TSSuperKeyword
TSSwitchKeyword
TSThisKeyword
TSThrowKeyword
TSTrueKeyword
TSTryKeyword
TSTypeKeyword
TSTypeOfKeyword
TSVarKeyword
TSWhileKeyword
TSWithKeyword
TSYieldKeyword

However, I’m not sure if they all actually appear in the AST.

@JamesHenry
Copy link
Member

Thanks a lot for contributing, @ikatyang!

@JamesHenry JamesHenry merged commit 9c71a62 into eslint:master Sep 25, 2017
@ikatyang ikatyang deleted the fix/symbol-keyword branch September 25, 2017 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants