Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update documentation about configuration hierarchy for CLIEngine options (fixes #9526) #9855

Merged
merged 1 commit into from Jan 18, 2018

Conversation

PiIsFour
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Added CLIEngine to the documentation under Configuration Cascading and Hierarchy to clarify the precedence of this configuration option.

Is there anything you'd like reviewers to focus on?
It's my first commit here. Tried to follow all the guides. Just mention anything I could do better.

@PiIsFour PiIsFour force-pushed the issue9526 branch 2 times, most recently from 5871a1b to 5c0ffed Compare January 17, 2018 23:34
Update documentation about configuration hierarchy for CLIEngine options
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@platinumazure platinumazure merged commit b96fb31 into eslint:master Jan 18, 2018
@platinumazure
Copy link
Member

Thanks @PiIsFour!

@PiIsFour PiIsFour deleted the issue9526 branch January 18, 2018 07:59
@PiIsFour
Copy link
Contributor Author

@platinumazure Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants