Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix substitution of {{ name }} #9822

Merged
merged 1 commit into from Jan 7, 2018
Merged

Conversation

mjomble
Copy link
Contributor

@mjomble mjomble commented Jan 7, 2018

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

The {{ name }} gets replaced with an empty string when rendered on the site: https://eslint.org/docs/developer-guide/working-with-rules#messageids
Based on the above example where {{ identifier }} is rendered properly, I'm guessing {% raw %} will fix that.

Is there anything you'd like reviewers to focus on?

I'm not 100% sure if this is the correct solution, so it should be tested first.

@jsf-clabot
Copy link

jsf-clabot commented Jan 7, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looks like I missed that.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants