Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Typo in "keyword-spacing" documentation? #9821

Merged
merged 1 commit into from Jan 9, 2018
Merged

Docs: Typo in "keyword-spacing" documentation? #9821

merged 1 commit into from Jan 9, 2018

Conversation

gov-ind
Copy link
Contributor

@gov-ind gov-ind commented Jan 7, 2018

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update

What changes did you make? (Give an overview)
Changed all instances of "not conflict" to "no conflict" in the "keyword-spacing" documentation.

Is there anything you'd like reviewers to focus on?
I hope "not conflict" means the same as "no conflict".

@jsf-clabot
Copy link

jsf-clabot commented Jan 7, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

Personally, I think "avoid conflict" would be even better. What do you think?

Also, could you please sign our CLA and edit your commit message and/or PR title to start with "Docs:", per our commit message guidelines? Thanks!

@gov-ind gov-ind changed the title Typo in "keyword-spacing" documentation? Docs: Typo in "keyword-spacing" documentation? Jan 8, 2018
@gov-ind
Copy link
Contributor Author

gov-ind commented Jan 8, 2018

Yeah, I think "avoid conflict" is much clearer. Just thought that I'd make a minimal change and keep it consistent by going with "no conflict".

Sorry about missing out on the guidelines - I've amended my commit message and the PR title. Hope its fine now.

@ilyavolodin
Copy link
Member

Thanks for PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants